qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/16] target/i386: cleanup eob handling of RSM


From: Richard Henderson
Subject: Re: [PATCH 02/16] target/i386: cleanup eob handling of RSM
Date: Fri, 24 May 2024 07:14:24 -0700
User-agent: Mozilla Thunderbird

On 5/24/24 01:10, Paolo Bonzini wrote:
gen_helper_rsm cannot generate an exception, and reloads the flags.
So there's no need to spill cc_op and update cpu_eip, but on the
other hand cc_op must be reset to CC_OP_EFLAGS before returning.

It all works by chance, because by spilling cc_op before the call
to the helper, it becomes non-dirty and gen_eob will not overwrite
the CC_OP_EFLAGS value that is placed there by the helper.  But
let's clean it up.

Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
---
  target/i386/tcg/translate.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]