RE: [PATCH 00/16] VFIO: misc cleanups part2

[Duan, Zhenzhong]

Hi Cédric,

>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Sent: Friday, May 17, 2024 12:48 AM
>To: Duan, Zhenzhong <zhenzhong.duan@intel.com>; qemu-
>devel@nongnu.org
>Cc: alex.williamson@redhat.com; eric.auger@redhat.com; Peng, Chao P
><chao.p.peng@intel.com>
>Subject: Re: [PATCH 00/16] VFIO: misc cleanups part2
>
>Hello Zhenzhong,
>
>On 5/15/24 10:20, Zhenzhong Duan wrote:
>> Hi
>>
>> This is the last round of cleanup series to change functions in hw/vfio/
>> to return bool when the error is passed through errp parameter.
>>
>> The first round is at https://lists.gnu.org/archive/html/qemu-devel/2024-
>05/msg01147.html
>>
>> I see Cédric is also working on some migration stuff cleanup,
>> so didn't touch migration.c, but all other files in hw/vfio/ are cleanup now.
>>
>> Patch1 is a fix patch, all others are cleanup patches.
>>
>> Test done on x86 platform:
>> vfio device hotplug/unplug with different backend
>> reboot
>>
>> This series is rebased to https://github.com/legoater/qemu/tree/vfio-next
>
>I queued part 1 in vfio-next with other changes. part 2 is in vfio-9.1
>for now and should reach vfio-next after reviews next week.
>
>Then, we have to work on your v5 [1] which should have all my attention
>again after the next vfio PR. You, Joao and Eric have followups series
>that need a resync on top of v5, possibly others [2] and [3], not sent
>AFAICT. Anyhow, we will need inputs from these people and IOMMU
>stakeholders/maintainers.

Thanks for sharing the plan.

+Joao, Eric, Michael, Jason, Nicolin, Clement for their awareness.

On my side, I have rebased nesting series on top of v5[1],
the newest patches at 
https://github.com/yiliu1765/qemu/commits/zhenzhong/iommufd_nesting_rfcv2/
is under internal review, FYI.

Thanks
Zhenzhong

>
>Thanks,
>
>C.
>
>[1] [PATCH v5 00/19] Add a host IOMMU device abstraction to check with
>vIOMMU
>     https://lore.kernel.org/qemu-devel/20240507092043.1172717-1-
>zhenzhong.duan@intel.com/
>
>[2] [PATCH ats_vtd v2 00/25] ATS support for VT-d
>     https://lore.kernel.org/all/20240515071057.33990-1-clement.mathieu--
>drif@eviden.com/
>
>[3] Add Tegra241 (Grace) CMDQV Support
>     https://lore.kernel.org/all/cover.1712978212.git.nicolinc@nvidia.com/
>     https://github.com/nicolinc/qemu/commits/wip/iommufd_vcmdq/
>
>
>
>>
>> Thanks
>> Zhenzhong
>>
>> Zhenzhong Duan (16):
>>    vfio/display: Fix error path in call site of ramfb_setup()
>>    vfio/display: Make vfio_display_*() return bool
>>    vfio/helpers: Use g_autofree in hw/vfio/helpers.c
>>    vfio/helpers: Make vfio_set_irq_signaling() return bool
>>    vfio/helpers: Make vfio_device_get_name() return bool
>>    vfio/platform: Make vfio_populate_device() and vfio_base_device_init()
>>      return bool
>>    vfio/ccw: Make vfio_ccw_get_region() return a bool
>>    vfio/pci: Make vfio_intx_enable_kvm() return a bool
>>    vfio/pci: Make vfio_pci_relocate_msix() and vfio_msix_early_setup()
>>      return a bool
>>    vfio/pci: Make vfio_populate_device() return a bool
>>    vfio/pci: Make vfio_intx_enable() return bool
>>    vfio/pci: Make vfio_populate_vga() return bool
>>    vfio/pci: Make capability related functions return bool
>>    vfio/pci: Use g_autofree for vfio_region_info pointer
>>    vfio/pci-quirks: Make vfio_pci_igd_opregion_init() return bool
>>    vfio/pci-quirks: Make vfio_add_*_cap() return bool
>>
>>   hw/vfio/pci.h                 |  12 +-
>>   include/hw/vfio/vfio-common.h |   6 +-
>>   hw/vfio/ap.c                  |  10 +-
>>   hw/vfio/ccw.c                 |  25 ++--
>>   hw/vfio/display.c             |  22 ++--
>>   hw/vfio/helpers.c             |  33 ++---
>>   hw/vfio/igd.c                 |   5 +-
>>   hw/vfio/pci-quirks.c          |  50 ++++----
>>   hw/vfio/pci.c                 | 227 ++++++++++++++++------------------
>>   hw/vfio/platform.c            |  61 ++++-----
>>   10 files changed, 213 insertions(+), 238 deletions(-)
>>