qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/3] Fix "virtio-gpu: fix scanout migration post-load"


From: Peter Xu
Subject: Re: [PATCH v4 0/3] Fix "virtio-gpu: fix scanout migration post-load"
Date: Thu, 16 May 2024 09:25:49 -0600

Looks good here, thanks.

On Thu, May 16, 2024, 2:40 a.m. <marcandre.lureau@redhat.com> wrote:
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

The aforementioned patch breaks virtio-gpu device migrations for versions
pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more
complex than it may initially appear, as evidenced in the problematic commit
dfcf74fa68c ("virtio-gpu: fix scanout migration post-load").

v2:
 - use a manual version field test (instead of the more complex struct variant)

v3:
 - introduce machine_check_version()
 - drop the VMSD version, and use machine version field test

v4:
 - drop machine_check_version() approach
 - property renamed to x-scanout-vmstate-version

Marc-André Lureau (3):
  migration: add "exists" info to load-state-field trace
  migration: fix a typo
  virtio-gpu: fix v2 migration

 include/hw/virtio/virtio-gpu.h |  1 +
 hw/core/machine.c              |  1 +
 hw/display/virtio-gpu.c        | 24 ++++++++++++++++--------
 migration/vmstate.c            |  7 ++++---
 migration/trace-events         |  2 +-
 5 files changed, 23 insertions(+), 12 deletions(-)

--
2.41.0.28.gd7d8841f67


reply via email to

[Prev in Thread] Current Thread [Next in Thread]