qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions t


From: BALATON Zoltan
Subject: Re: [PATCH v2 26/28] target/ppc/mmu_common.c: Move BookE MMU functions together
Date: Tue, 7 May 2024 17:54:11 +0200 (CEST)

On Tue, 7 May 2024, Nicholas Piggin wrote:
What do you think about adding mmu-book3e.c instead?

Now I remember that besides possible performance loss because of loss of automatic inline if not all functions are static the other reason was that these functions use mmu_ctx_t that I don't want to export. Howerver these booke functions only use the raddr and ctx fields so there should be no reason to use the ctx and I had a patch to do that but dropped it trying to simplify the series and come back to it later. I might try to get that back to see if it helps with some used uninit warnings but I'm not sure it would.

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]