[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/21] migration: Do not call PRECOPY_NOTIFY_SETUP notifie
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v2 04/21] migration: Do not call PRECOPY_NOTIFY_SETUP notifiers in case of error |
|
Date: |
Thu, 29 Feb 2024 12:12:35 +0800 |
On Tue, Feb 27, 2024 at 07:03:28PM +0100, Cédric Le Goater wrote:
> When commit bd2270608fa0 ("migration/ram.c: add a notifier chain for
> precopy") added PRECOPY_NOTIFY_SETUP notifiers at the end of
> qemu_savevm_state_setup(), it didn't take into account a possible
> error in the loop calling vmstate_save() or .save_setup() handlers.
>
> Check ret value before calling the notifiers.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v2 00/21] migration: Improve error reporting, Cédric Le Goater, 2024/02/27
- [PATCH v2 04/21] migration: Do not call PRECOPY_NOTIFY_SETUP notifiers in case of error, Cédric Le Goater, 2024/02/27
- Re: [PATCH v2 04/21] migration: Do not call PRECOPY_NOTIFY_SETUP notifiers in case of error,
Peter Xu <=
- [PATCH v2 18/21] memory: Add Error** argument to memory_get_xlat_addr(), Cédric Le Goater, 2024/02/27
- [PATCH v2 10/21] migration: Modify ram_init_bitmaps() to report dirty tracking errors, Cédric Le Goater, 2024/02/27
- [PATCH v2 12/21] vfio: Add Error** argument to .set_dirty_page_tracking() handler, Cédric Le Goater, 2024/02/27
- [PATCH v2 15/21] vfio: Use new Error** argument in vfio_save_setup(), Cédric Le Goater, 2024/02/27
- [PATCH v2 11/21] migration: Fix migration termination, Cédric Le Goater, 2024/02/27
- [PATCH v2 17/21] vfio: Reverse test on vfio_get_dirty_bitmap(), Cédric Le Goater, 2024/02/27
- [PATCH v2 01/21] migration: Report error when shutdown fails, Cédric Le Goater, 2024/02/27
- [PATCH v2 20/21] vfio: Also trace event failures in vfio_save_complete_precopy(), Cédric Le Goater, 2024/02/27