[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/7] migration/multifd: Implement zero page transmission o
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 2/7] migration/multifd: Implement zero page transmission on the multifd thread. |
Date: |
Wed, 28 Feb 2024 10:45:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hao Xiang <hao.xiang@bytedance.com> writes:
> 1. Add zero_pages field in MultiFDPacket_t.
> 2. Implements the zero page detection and handling on the multifd
> threads for non-compression, zlib and zstd compression backends.
> 3. Added a new value 'multifd' in ZeroPageDetection enumeration.
> 4. Handle migration QEMU9.0 -> QEMU8.2 compatibility.
> 5. Adds zero page counters and updates multifd send/receive tracing
> format to track the newly added counters.
>
> Signed-off-by: Hao Xiang <hao.xiang@bytedance.com>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 1e66272f8f..5a1bb8ad62 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -660,10 +660,13 @@
> #
> # @legacy: Perform zero page checking from main migration thread.
> #
> +# @multifd: Perform zero page checking from multifd sender thread.
> +#
Make that "in thread" instead of "from thread". Both occurences,
i.e. here for @multifd, and in PATCH 1 for @legacy.
> # Since: 9.0
> +#
> ##
> { 'enum': 'ZeroPageDetection',
> - 'data': [ 'none', 'legacy' ] }
> + 'data': [ 'none', 'legacy', 'multifd' ] }
>
> ##
> # @BitmapMigrationBitmapAliasTransform:
Re: [PATCH v3 2/7] migration/multifd: Implement zero page transmission on the multifd thread., Fabiano Rosas, 2024/02/28
[PATCH v3 3/7] migration/multifd: Implement ram_save_target_page_multifd to handle multifd version of MigrationOps::ram_save_target_page., Hao Xiang, 2024/02/26
[PATCH v3 4/7] migration/multifd: Enable multifd zero page checking by default., Hao Xiang, 2024/02/26