Re: TCG change broke MorphOS boot on sam460ex

[BALATON Zoltan]

On Tue, 27 Feb 2024, Philippe Mathieu-Daudé wrote:
> Hi Zoltan,
>
> On 27/2/24 17:47, BALATON Zoltan wrote:
> > Hello,
> >
> > Commit 18a536f1f8 (accel/tcg: Always require can_do_io) broke booting 
> > MorphOS on sam460ex (this was before 8.2.0 and I thought I've verified it 
> > before that release but apparently missed it back then). It can be 
> > reproduced with https://www.morphos-team.net/morphos-3.18.iso and following 
> > command:
> >
> > qemu-system-ppc -M sam460ex -serial stdio -d unimp,guest_errors \
> >    -drive if=none,id=cd,format=raw,file=morphos-3.18.iso \
> >    -device ide-cd,drive=cd,bus=ide.1
> >
> > before:
> > Invalid read at addr 0xC08001216, size 1, region '(null)', reason: rejected
> > Invalid read at addr 0x216, size 1, region '(null)', reason: rejected
> > Invalid read at addr 0x4FDF6BFB0, size 4, region '(null)', reason: rejected
> > Invalid write at addr 0xE10000014, size 4, region '(null)', reason: 
> > rejected
> > Invalid write at addr 0xE10000214, size 4, region '(null)', reason: 
> > rejected
> > Invalid write at addr 0xE30000014, size 4, region '(null)', reason: 
> > rejected
> > Invalid write at addr 0xE30000214, size 4, region '(null)', reason: 
> > rejected
> > 8.440| sam460_i2c_write: Error while writing, sts 34
> > 8.463|
> > 8.463|
> > 8.463| ABox 1.30 (2.7.2018)...
> >
> > after:
> > Invalid read at addr 0xC08001216, size 1, region '(null)', reason: rejected
> > Invalid read at addr 0x216, size 1, region '(null)', reason: rejected
> > Invalid read at addr 0x4F0C01374, size 4, region '(null)', reason: rejected
> > invalid/unsupported opcode: 00 - 00 - 00 - 00 (00000000) 00c01374
> > Invalid read at addr 0x4F0000700, size 4, region '(null)', reason: rejected
> > invalid/unsupported opcode: 00 - 00 - 00 - 00 (00000000) 00000700
> >
> > Not sure what it's trying to do here, maybe decompressing some code and 
> > then trying to execute it? Any idea what could be the problem or what to 
> > check further?
>
> Are you testing with commit cf9b5790db ("accel/tcg: Remove CF_LAST_IO")
> included?

The issue happens starting with commit 18a536f1f8 and present even in 
current master. The commit before it (200c1f904f accel/tcg: Always set 
CF_LAST_IO with CF_NOIRQ) still works. Commit cf9b5790db does not work.

Regards,
BALATON Zoltan