[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/30] hw/sh4/r2d: do not use usb_bus_find()
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 12/30] hw/sh4/r2d: do not use usb_bus_find() |
Date: |
Tue, 27 Feb 2024 09:39:28 +0100 |
From: Paolo Bonzini <pbonzini@redhat.com>
usb_bus_find() is always used with argument -1; it can be replaced with
a search of the single USB bus on the machine.
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20240223124406.234509-4-pbonzini@redhat.com>
[PMD: Fixed style]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sh4/r2d.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index c73e8f49b8..e5ac6751bd 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -244,6 +244,7 @@ static void r2d_init(MachineState *machine)
SysBusDevice *busdev;
MemoryRegion *address_space_mem = get_system_memory();
PCIBus *pci_bus;
+ USBBus *usb_bus;
cpu = SUPERH_CPU(cpu_create(machine->cpu_type));
env = &cpu->env;
@@ -312,7 +313,9 @@ static void r2d_init(MachineState *machine)
pci_init_nic_devices(pci_bus, mc->default_nic);
/* USB keyboard */
- usb_create_simple(usb_bus_find(-1), "usb-kbd");
+ usb_bus = USB_BUS(object_resolve_type_unambiguous(TYPE_USB_BUS,
+ &error_abort));
+ usb_create_simple(usb_bus, "usb-kbd");
/* Todo: register on board registers */
memset(&boot_params, 0, sizeof(boot_params));
--
2.41.0
- [PULL 02/30] hw/display/pl110: Pass frame buffer memory region as link property, (continued)
- [PULL 02/30] hw/display/pl110: Pass frame buffer memory region as link property, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 03/30] hw/arm/exynos4210: Inline sysbus_create_varargs(EXYNOS4210_FIMD), Philippe Mathieu-Daudé, 2024/02/27
- [PULL 05/30] hw/i386/kvmvapic: Inline sysbus_address_space(), Philippe Mathieu-Daudé, 2024/02/27
- [PULL 04/30] hw/display/exynos4210_fimd: Pass frame buffer memory region as link, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 06/30] hw/sysbus: Remove now unused sysbus_address_space(), Philippe Mathieu-Daudé, 2024/02/27
- [PULL 07/30] hw/nubus-device: round Declaration ROM memory region address to qemu_target_page_size(), Philippe Mathieu-Daudé, 2024/02/27
- [PULL 08/30] hw/nubus: increase maximum Declaration ROM size from 128k to 1Mb, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 09/30] hw/nubus: add nubus-virtio-mmio device, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 10/30] hw/acpi: move object_resolve_type_unambiguous to core QOM, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 11/30] hw/ppc/sam460ex: do not use usb_bus_find(), Philippe Mathieu-Daudé, 2024/02/27
- [PULL 12/30] hw/sh4/r2d: do not use usb_bus_find(),
Philippe Mathieu-Daudé <=
- [PULL 13/30] hw/mips/loongson3_virt: do not require CONFIG_USB, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 14/30] hw/hppa: do not require CONFIG_USB, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 16/30] hw/ppc/pseries: do not require CONFIG_USB, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 17/30] hw/usb: remove usb_bus_find, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 15/30] hw/ppc/mac_newworld: do not require CONFIG_USB, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 18/30] hw/usb: extract sysbus-ohci to a separate file, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 19/30] hw/usb: remove duplicate file in system_ss, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 21/30] hw/i386/x86: Let ioapic_init_gsi() take parent as pointer, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 22/30] hw/i386/sgx: Use QDev API, Philippe Mathieu-Daudé, 2024/02/27
- [PULL 20/30] hw/nvme: fix invalid endian conversion, Philippe Mathieu-Daudé, 2024/02/27