[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplif
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling |
|
Date: |
Mon, 26 Feb 2024 14:19:03 +0000 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Thu, Feb 22, 2024 at 12:15:43AM +0300, Michael Tokarev wrote:
> qemu_opt_set_number() expects signed int64_t.
>
> Use int64_t instead of uint64_t for img_size, use -1 as "unset"
> value instead of UINT64_MAX, and do not require temporary sval
> for conversion from string.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> qemu-img.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, (continued)
- [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21
- [PATCH 06/28] qemu-img: create: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 01/28] qemu-img: stop printing error twice in a few places, Michael Tokarev, 2024/02/21
- [PATCH 05/28] qemu-img: pass current cmd info into command handlers, Michael Tokarev, 2024/02/21
- [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21
- Re: [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling,
Daniel P . Berrangé <=
- [PATCH 09/28] qemu-img: simplify --repair error message, Michael Tokarev, 2024/02/21
- [PATCH 07/28] qemu-img: factor out parse_output_format() and use it in the code, Michael Tokarev, 2024/02/21
- [PATCH 08/28] qemu-img: check: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 12/28] qemu-img: convert: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 10/28] qemu-img: commit: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 11/28] qemu-img: compare: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 14/28] qemu-img: map: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 13/28] qemu-img: info: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 16/28] qemu-img: snapshot: make -l (list) the default, simplify option handling, Michael Tokarev, 2024/02/21