qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/9] hw/i386/pc: Confine system flash handling to pc_sysfw


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 6/9] hw/i386/pc: Confine system flash handling to pc_sysfw
Date: Wed, 21 Feb 2024 17:09:38 +0100
User-agent: Mozilla Thunderbird

On 8/2/24 23:03, Bernhard Beschow wrote:
Rather than distributing PC system flash handling across three files, let's
confine it to one. Now, pc_system_firmware_init() creates, configures and cleans
up the system flash which makes the code easier to understand. It also avoids
the extra call to pc_system_flash_cleanup_unused() in the Xen case.

Maybe add " because pc_memory_init() is not called by Xen."


Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
  include/hw/i386/pc.h | 2 --
  hw/i386/pc.c         | 1 -
  hw/i386/pc_piix.c    | 1 -
  hw/i386/pc_sysfw.c   | 6 ++++--
  4 files changed, 4 insertions(+), 6 deletions(-)

Nice!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]