[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/23] qemu-img: allow specifying -f fmt for snapshot subcomm
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 11/23] qemu-img: allow specifying -f fmt for snapshot subcommand |
Date: |
Tue, 20 Feb 2024 17:41:49 +0000 |
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Sat, Feb 10, 2024 at 12:22:32AM +0300, Michael Tokarev wrote:
> For consistency with other commands, and since it already
> accepts --image-opts, allow specifying -f fmt too.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> docs/tools/qemu-img.rst | 2 +-
> qemu-img-cmds.hx | 4 ++--
> qemu-img.c | 9 ++++++---
> 3 files changed, 9 insertions(+), 6 deletions(-)
With the fix you already mentioned for getopt:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 04/23] qemu-img: refresh options/--help for "check" command, (continued)
- [PATCH 04/23] qemu-img: refresh options/--help for "check" command, Michael Tokarev, 2024/02/09
- [PATCH 05/23] qemu-img: simplify --repair error message, Michael Tokarev, 2024/02/09
- [PATCH 06/23] qemu-img: refresh options/--help for "commit" command, Michael Tokarev, 2024/02/09
- [PATCH 07/23] qemu-img: refresh options/--help for "compare" command, Michael Tokarev, 2024/02/09
- [PATCH 08/23] qemu-img: refresh options/--help for "convert" command, Michael Tokarev, 2024/02/09
- [PATCH 09/23] qemu-img: refresh options/--help for "info" command, Michael Tokarev, 2024/02/09
- [PATCH 10/23] qemu-img: refresh options/--help for "map" command, Michael Tokarev, 2024/02/09
- [PATCH 11/23] qemu-img: allow specifying -f fmt for snapshot subcommand, Michael Tokarev, 2024/02/09
- [PATCH 13/23] qemu-img: refresh options/--help for "snapshot" command, Michael Tokarev, 2024/02/09
- [PATCH 14/23] qemu-img: refresh options/--help for "rebase" command, Michael Tokarev, 2024/02/09
- [PATCH 15/23] qemu-img: resize: do not always eat last argument, Michael Tokarev, 2024/02/09
- [PATCH 16/23] qemu-img: refresh options/--help for "resize" command, Michael Tokarev, 2024/02/09
- [PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand, Michael Tokarev, 2024/02/09