Re: [PATCH 0/4] hw/nmi: Remove @cpu_index argument

[Thomas Huth]

On 20/02/2024 16.08, Philippe Mathieu-Daudé wrote:
> Have s390x always deliver NMI to the first CPU,
> remove the @cpu_index argument from handler,
> rename API as nmi_trigger() (not monitor specific).

Could you please add some rationale here why this is needed / desired?

Thanks,
 Thomas


> Philippe Mathieu-Daudé (4):
>    hw/nmi: Use object_child_foreach_recursive() in nmi_children()
>    hw/s390x/virtio-ccw: Always deliver NMI to first CPU
>    hw/nmi: Remove @cpu_index argument from NMIClass::nmi_handler()
>    hw/nmi: Remove @cpu_index argument from nmi_trigger()
>
>   qapi/run-state.json        |  5 +++--
>   include/hw/nmi.h           | 24 ++++++++++++++++++++++--
>   hw/core/nmi.c              | 24 +++++++++---------------
>   hw/hppa/machine.c          |  8 +++++---
>   hw/i386/x86.c              |  7 ++++---
>   hw/intc/m68k_irqc.c        |  6 ++++--
>   hw/ipmi/ipmi.c             |  3 +--
>   hw/m68k/q800-glue.c        |  6 ++++--
>   hw/misc/macio/gpio.c       |  6 ++++--
>   hw/ppc/pnv.c               |  6 ++++--
>   hw/ppc/spapr.c             |  6 ++++--
>   hw/s390x/s390-virtio-ccw.c |  8 ++++----
>   hw/watchdog/watchdog.c     |  2 +-
>   system/cpus.c              |  2 +-
>   hmp-commands.hx            |  2 +-
>   15 files changed, 71 insertions(+), 44 deletions(-)