[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/7] block: Support detached LUKS header creation using bl
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create |
|
Date: |
Mon, 19 Feb 2024 16:43:33 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Daniel P. Berrangé <berrange@redhat.com> writes:
[...]
> TL;DR: the @detached-header field needs to go, as that's supposed to
> be internal only. The mgmt app should only care about 'header' in the
> BlockdevCreateOptionsLUKS struct.
>
> FYI, this whole series is already merged last week. So this will need
> a fixup. I'll look into it now.
Glad I neglected to check for a merge, because if I had, I wouldn't have
looked at the schema :)
My apologies for looking so late!
[...]