[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/36] linux-user: Remove qemu_host_page_size from create_elf_
From: |
Richard Henderson |
Subject: |
[PATCH v4 04/36] linux-user: Remove qemu_host_page_size from create_elf_tables |
Date: |
Wed, 14 Feb 2024 20:19:46 -1000 |
AT_PAGESZ is supposed to advertise the guest page size.
The random adjustment made here using qemu_host_page_size
does not match anything else within linux-user.
The idea here is good, but should be done more systemically
via adjustment to TARGET_PAGE_SIZE.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-5-richard.henderson@linaro.org>
---
linux-user/elfload.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index e84a201448..dfb152bfcb 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2679,13 +2679,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int
argc, int envc,
NEW_AUX_ENT(AT_PHDR, (abi_ulong)(info->load_addr + exec->e_phoff));
NEW_AUX_ENT(AT_PHENT, (abi_ulong)(sizeof (struct elf_phdr)));
NEW_AUX_ENT(AT_PHNUM, (abi_ulong)(exec->e_phnum));
- if ((info->alignment & ~qemu_host_page_mask) != 0) {
- /* Target doesn't support host page size alignment */
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
- } else {
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(MAX(TARGET_PAGE_SIZE,
- qemu_host_page_size)));
- }
+ NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
NEW_AUX_ENT(AT_BASE, (abi_ulong)(interp_info ? interp_info->load_addr :
0));
NEW_AUX_ENT(AT_FLAGS, (abi_ulong)0);
NEW_AUX_ENT(AT_ENTRY, info->entry);
--
2.34.1
- [PATCH v4 00/36] linux-user: Improve host and guest page size handling, Richard Henderson, 2024/02/15
- [PATCH v4 03/36] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base, Richard Henderson, 2024/02/15
- [PATCH v4 04/36] linux-user: Remove qemu_host_page_size from create_elf_tables,
Richard Henderson <=
- [PATCH v4 05/36] linux-user/hppa: Simplify init_guest_commpage, Richard Henderson, 2024/02/15
- [PATCH v4 06/36] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/15
- [PATCH v4 07/36] linux-user/arm: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/15
- [PATCH v4 09/36] linux-user: Remove REAL_HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/15
- [PATCH v4 10/36] linux-user: Remove HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/15
- [PATCH v4 11/36] migration: Remove qemu_host_page_size, Richard Henderson, 2024/02/15
- [PATCH v4 14/36] softmmu/physmem: Remove HOST_PAGE_ALIGN, Richard Henderson, 2024/02/15
- [PATCH v4 13/36] softmmu/physmem: Remove qemu_host_page_size, Richard Henderson, 2024/02/15
- [PATCH v4 16/36] linux-user: Split out target_mmap__locked, Richard Henderson, 2024/02/15
- [PATCH v4 17/36] linux-user: Move some mmap checks outside the lock, Richard Henderson, 2024/02/15