[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 56/60] hw/smbios: Fix port connector option validation
From: |
Michael S. Tsirkin |
Subject: |
[PULL 56/60] hw/smbios: Fix port connector option validation |
Date: |
Wed, 14 Feb 2024 06:16:11 -0500 |
From: Akihiko Odaki <akihiko.odaki@daynix.com>
qemu_smbios_type8_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.
Cc: qemu-stable@nongnu.org
Fixes: fd8caa253c56 ("hw/smbios: support for type 8 (port connector)")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20240129-smbios-v2-2-9ee6fede0d10@daynix.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/smbios/smbios.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index a9048c1342..a3c4e52ce9 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -352,6 +352,11 @@ static const QemuOptDesc qemu_smbios_type4_opts[] = {
};
static const QemuOptDesc qemu_smbios_type8_opts[] = {
+ {
+ .name = "type",
+ .type = QEMU_OPT_NUMBER,
+ .help = "SMBIOS element type",
+ },
{
.name = "internal_reference",
.type = QEMU_OPT_STRING,
@@ -372,6 +377,7 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = {
.type = QEMU_OPT_NUMBER,
.help = "port type",
},
+ { /* end of list */ }
};
static const QemuOptDesc qemu_smbios_type11_opts[] = {
--
MST
- [PULL 37/60] cxl/cdat: Handle cdat table build errors, (continued)
- [PULL 37/60] cxl/cdat: Handle cdat table build errors, Michael S. Tsirkin, 2024/02/14
- [PULL 38/60] hw/mem/cxl_type3: Drop handling of failure of g_malloc0() and g_malloc(), Michael S. Tsirkin, 2024/02/14
- [PULL 43/60] hw/cxl: Pass CXLComponentState to cache_mem_ops, Michael S. Tsirkin, 2024/02/14
- [PULL 44/60] hw/cxl: Pass NULL for a NULL MemoryRegionOps, Michael S. Tsirkin, 2024/02/14
- [PULL 45/60] hw/mem/cxl_type3: Fix potential divide by zero reported by coverity, Michael S. Tsirkin, 2024/02/14
- [PULL 48/60] tests/acpi: Update DSDT.cxl to reflect change _STA return value., Michael S. Tsirkin, 2024/02/14
- [PULL 50/60] hw/cxl: Update link register definitions., Michael S. Tsirkin, 2024/02/14
- [PULL 54/60] virtio-gpu: Correct virgl_renderer_resource_get_info() error check, Michael S. Tsirkin, 2024/02/14
- [PULL 53/60] hw/cxl: Standardize all references on CXL r3.1 and minor updates, Michael S. Tsirkin, 2024/02/14
- [PULL 55/60] hw/smbios: Fix OEM strings table option validation, Michael S. Tsirkin, 2024/02/14
- [PULL 56/60] hw/smbios: Fix port connector option validation,
Michael S. Tsirkin <=
- [PULL 51/60] hw/cxl: Update RAS Capability Definitions for version 3., Michael S. Tsirkin, 2024/02/14
- [PULL 49/60] hw/cxl: Update HDM Decoder capability to version 3, Michael S. Tsirkin, 2024/02/14
- [PULL 52/60] hw/cxl: Update mailbox status registers., Michael S. Tsirkin, 2024/02/14
- [PULL 58/60] virtio-gpu.c: add resource_destroy class method, Michael S. Tsirkin, 2024/02/14
- [PULL 57/60] hw/display/virtio-gpu.c: use reset_bh class method, Michael S. Tsirkin, 2024/02/14
- [PULL 59/60] virtio-gpu-rutabaga.c: override resource_destroy method, Michael S. Tsirkin, 2024/02/14
- [PULL 60/60] MAINTAINERS: Switch to my Enfabrica email, Michael S. Tsirkin, 2024/02/14
- Re: [PULL 00/60] virtio,pc,pci: features, cleanups, fixes, Michael S. Tsirkin, 2024/02/14
- [PULL 22/60] hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus, Michael S. Tsirkin, 2024/02/14