Re: [PATCH v1 00/15] libvhost-user: support more memslots and cleanup memslot handling code

[Michael S. Tsirkin]

On Tue, Feb 13, 2024 at 07:27:44PM +0100, David Hildenbrand wrote:
> On 13.02.24 18:33, Michael S. Tsirkin wrote:
> > On Fri, Feb 02, 2024 at 10:53:17PM +0100, David Hildenbrand wrote:
> > > This series adds support for more memslots (509) to libvhost-user, to
> > > make it fully compatible with virtio-mem that uses up to 256 memslots
> > > accross all memory devices in "dynamic-memslot" mode (more details
> > > in patch #3).
> > 
> > 
> > Breaks build on some systems. E.g.
> > https://gitlab.com/mstredhat/qemu/-/jobs/6163591599
> > 
> > 
> 
> ./subprojects/libvhost-user/libvhost-user.c:369:27: error: comparison of
> integer expressions of different signedness: ‘long int’ and ‘unsigned int’
> [-Werror=sign-compare]
>   369 |     if (!ret && fs.f_type == HUGETLBFS_MAGIC) {
>       |                           ^~
> 
> So easy to fix in v2, thanks!


I think there is another problem around plugins though.


> -- 
> Cheers,
> 
> David / dhildenb