qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 05/17] plugins: scoreboard API


From: Pierrick Bouvier
Subject: Re: [PATCH v3 05/17] plugins: scoreboard API
Date: Mon, 12 Feb 2024 10:24:12 +0400
User-agent: Mozilla Thunderbird

On 2/11/24 23:13, Richard Henderson wrote:
On 2/11/24 04:26, Pierrick Bouvier wrote:
On 2/11/24 04:41, Richard Henderson wrote:
On 2/6/24 19:59, Pierrick Bouvier wrote:
Why a hash table?  All you want is to be able to iterate through all, and 
add/remove
easily.  Seems like QLIST from <qemu/queue.h> would be better, and the 
QLIST_ENTRY member
would make struct qemu_plugin_scoreboard useful.


Thought that having O(1) removal was a nice property, compared to a linked 
list. I can
switch to a QLIST if you still think it's better.

QLIST is double-linked, so it's still O(1).



Is it an "intrusive" linked list (where next and prev are part of the struct 
entry itself)?

Yes.


Sounds good then, I'll switch to QLIST.


r~

reply via email to

[Prev in Thread] Current Thread [Next in Thread]