Re: [PATCH v2 0/5] virtio-blk: iothread-vq-mapping cleanups

[Michael S. Tsirkin]

On Tue, Feb 06, 2024 at 02:06:05PM -0500, Stefan Hajnoczi wrote:
> v2:
> - Add comment in Patch 3 explaining why bounds check assertion [Manos]
> - Remove redundant nested if in Patch 1 [Hanna]
> 
> Hanna reviewed the iothread-vq-mapping patches after they were applied to
> qemu.git. This series consists of code cleanups that Hanna identified.
> 
> There are no functional changes or bug fixes that need to be backported to the
> stable tree here, but it may make sense to backport them in the future to 
> avoid
> conflicts.

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>




> Stefan Hajnoczi (5):
>   virtio-blk: enforce iothread-vq-mapping validation
>   virtio-blk: clarify that there is at least 1 virtqueue
>   virtio-blk: add vq_rq[] bounds check in virtio_blk_dma_restart_cb()
>   virtio-blk: declare VirtIOBlock::rq with a type
>   monitor: use aio_co_reschedule_self()
> 
>  include/hw/virtio/virtio-blk.h |   2 +-
>  hw/block/virtio-blk.c          | 194 ++++++++++++++++++---------------
>  qapi/qmp-dispatch.c            |   7 +-
>  3 files changed, 112 insertions(+), 91 deletions(-)
> 
> -- 
> 2.43.0