Re: [PATCH v3 07/46] hw/alpha/dp264: use pci_init_nic_devices()

[Thomas Huth]

On 08/01/2024 21.26, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   hw/alpha/dp264.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
> index 03495e1e60..52a1fa310b 100644
> --- a/hw/alpha/dp264.c
> +++ b/hw/alpha/dp264.c
> @@ -124,9 +124,7 @@ static void clipper_init(MachineState *machine)
>       pci_vga_init(pci_bus);
>   
>       /* Network setup.  e1000 is good enough, failing Tulip support.  */
> -    for (i = 0; i < nb_nics; i++) {
> -        pci_nic_init_nofail(&nd_table[i], pci_bus, mc->default_nic, NULL);
> -    }
> +    pci_init_nic_devices(pci_bus, mc->default_nic);
>   
>       /* Super I/O */
>       isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO);

Reviewed-by: Thomas Huth <thuth@redhat.com>