qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/12] plugins: implement inline operation with cpu_index off


From: Richard Henderson
Subject: Re: [PATCH 01/12] plugins: implement inline operation with cpu_index offset
Date: Sat, 13 Jan 2024 09:22:43 +1100
User-agent: Mozilla Thunderbird

On 1/13/24 01:27, Pierrick Bouvier wrote:
On 1/12/24 02:04, Richard Henderson wrote:
On 1/12/24 01:23, Pierrick Bouvier wrote:
Instead of working on a fixed memory location, allow to index it based
on cpu_index and a given offset (ptr + cpu_index * offset).
Current semantic is not modified as we use a 0 offset, thus inline
operation still targets always the same memory location.

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
   accel/tcg/plugin-gen.c | 60 +++++++++++++++++++++++++++++++++++-------
   include/qemu/plugin.h  |  1 +
   plugins/api.c          |  7 ++---
   plugins/core.c         | 11 +++++---
   plugins/plugin.h       |  5 ++--
   5 files changed, 65 insertions(+), 19 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

For the to-do list: add mul -> shl strength reduction in fold_mul().


Would you like me to add a todo somewhere about it? Or is it a reminder for 
follow-up work?

It's a reminder to myself for follow-up-work.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]