Re: [PATCH v2 12/43] qtest: bump boot-serial-test timeout to 3 minutes

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> On 03/01/2024 18.33, Alex Bennée wrote:
>> From: Daniel P. Berrangé <berrange@redhat.com>
>> The boot-serial-test takes about 1 + 1/2 minutes in a --enable-debug
>> build. Bumping to 3 minutes will give more headroom.
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>> Message-ID: <20230717182859.707658-9-berrange@redhat.com>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> Message-Id: <20231215070357.10888-9-thuth@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   tests/qtest/meson.build | 1 +
>>   1 file changed, 1 insertion(+)
>> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
>> index c7944e8dbe9..dc1e6da5c7b 100644
>> --- a/tests/qtest/meson.build
>> +++ b/tests/qtest/meson.build
>> @@ -6,6 +6,7 @@ slow_qtests = {
>>     'test-hmp' : 240,
>>     'pxe-test': 600,
>>     'prom-env-test': 360,
>> +  'boot-serial-test': 180,
>>   }
>>     qtests_generic = [
>
> 3 minutes was obviously not enough:
>
>  https://gitlab.com/qemu-project/qemu/-/jobs/5918818492#L4984
>
> And in older runs, we can see that the boot-serial-test might take
> longer than 180s when run with TCI :
>
>  https://gitlab.com/qemu-project/qemu/-/jobs/5890481086#L4772
>
> So I think we should bump the timeout to 240s here. Alex, are you
> going to respin your pull request? If so, could you modify your patch?
> Otherwise I can also send a new version of this patch here, just let
> me know.

I'm travelling now so its tricky to respin. If you could send a new
version that would be great.


>
>  Thomas

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro