[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/2] hmp: Drop unknown feature and status bits
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 2/2] hmp: Drop unknown feature and status bits |
Date: |
Fri, 12 Jan 2024 15:03:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hyman Huang <yong.huang@smartx.com> writes:
> The QMP command "x-query-virtio-status" outputs the full
> feature and status bit information, so there is no need
> to maintain it in the HMP output; drop it.
>
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
I'm not sure hiding unknown bits from HMP users is a good idea. Sure,
you can use QMP to find them, but why would you when HMP gives no clue
that its output is incomplete?
I'd simply keep them, i.e. drop this patch.