qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] virtio: add VIRTQUEUE_ERROR QAPI event


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v4] virtio: add VIRTQUEUE_ERROR QAPI event
Date: Tue, 9 Jan 2024 16:30:01 +0300
User-agent: Mozilla Thunderbird

ping2 )

On 08.11.23 12:53, Vladimir Sementsov-Ogievskiy wrote:
ping :)

On 17.10.23 15:39, Vladimir Sementsov-Ogievskiy wrote:
For now we only log the vhost device error, when virtqueue is actually
stopped. Let's add a QAPI event, which makes possible:

  - collect statistics of such errors
  - make immediate actions: take core dumps or do some other debugging
  - inform the user through a management API or UI, so that (s)he can
   react somehow, e.g. reset the device driver in the guest or even
   build up some automation to do so

Note that basically every inconsistency discovered during virtqueue
processing results in a silent virtqueue stop.  The guest then just
sees the requests getting stuck somewhere in the device for no visible
reason.  This event provides a means to inform the management layer of
this situation in a timely fashion.

The event could be reused for some other virtqueue problems (not only
for vhost devices) in future. For this it gets a generic name and
structure.

We keep original VHOST_OPS_DEBUG(), to keep original debug output as is
here, it's not the only call to VHOST_OPS_DEBUG in the file.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>
Acked-by: Markus Armbruster <armbru@redhat.com>
---

v4: add spacing between @arguments in qapi doc
     add a-b by Markus


--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]