[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/9] tests/avocado: Enable replay_linux.py on ppc64 pseries
From: |
Nicholas Piggin |
Subject: |
[PATCH 4/9] tests/avocado: Enable replay_linux.py on ppc64 pseries |
Date: |
Mon, 8 Jan 2024 03:01:14 +1000 |
Add a ppc64 pseries test. This tends to hang in the replay phase near
the end of the trace due to a missing event, so it is marked flaky.
spapr-vscsi IO is extremely slow when running in record-replay modes,
particularly when driven by SLOF. This causes tests to time-out even
after an hour, so this uses guestfish to extract the kernel and initrd
and boot them directly.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/avocado/replay_linux.py | 76 ++++++++++++++++++++++++++++++++++-
1 file changed, 75 insertions(+), 1 deletion(-)
diff --git a/tests/avocado/replay_linux.py b/tests/avocado/replay_linux.py
index 270ccc1eae..82daba9f3f 100644
--- a/tests/avocado/replay_linux.py
+++ b/tests/avocado/replay_linux.py
@@ -11,8 +11,9 @@
import os
import logging
import time
+import subprocess
-from avocado import skipUnless
+from avocado import skipIf, skipUnless
from avocado_qemu import BUILD_DIR
from avocado.utils import cloudinit
from avocado.utils import network
@@ -191,3 +192,76 @@ def test_virt_gicv3(self):
self.run_rr(shift=3,
args=(*self.get_common_args(),
"-machine", "virt,gic-version=3"))
+
+# ppc64 pseries test.
+#
+# This machine tends to fail replay and hang very close to the end of the
+# trace, with missing events, which is still an open issue.
+#
+# spapr-scsi IO driven by SLOF/grub is extremely slow in record/replay mode,
+# so jump through some hoops to boot the kernel directly. With this, the test
+# runs in about 5 minutes (modulo hang), which suggests other machines may
+# have similar issues and could benefit from bypassing bootloaders.
+#
+ppc_deps = ["guestfish"] # dependent tools needed in the test setup/box.
+
+def which(tool):
+ """ looks up the full path for @tool, returns None if not found
+ or if @tool does not have executable permissions.
+ """
+ paths=os.getenv('PATH')
+ for p in paths.split(os.path.pathsep):
+ p = os.path.join(p, tool)
+ if os.path.exists(p) and os.access(p, os.X_OK):
+ return p
+ return None
+
+def ppc_missing_deps():
+ """ returns True if any of the test dependent tools are absent.
+ """
+ for dep in ppc_deps:
+ if which(dep) is None:
+ return True
+ return False
+
+@skipIf(ppc_missing_deps(), 'dependencies (%s) not installed' %
','.join(ppc_deps))
+@skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), 'known failure in trace
replay')
+class ReplayLinuxPPC64(ReplayLinux):
+ """
+ :avocado: tags=arch:ppc64
+ :avocado: tags=accel:tcg
+ """
+
+ hdd = 'scsi-hd'
+ cd = 'scsi-cd'
+ bus = None
+
+ def setUp(self):
+ super().setUp()
+
+ # kernel, initramfs, and kernel cmdline are all taken by hand from
+ # the Fedora image.
+ self.kernel="vmlinuz-5.3.7-301.fc31.ppc64le"
+ self.initramfs="initramfs-5.3.7-301.fc31.ppc64le.img"
+ cmd = "guestfish --ro -a %s run "
+ ": mount /dev/sda2 / "
+ ": copy-out /boot/%s %s "
+ ": copy-out /boot/%s %s "
+ % (self.boot_path, self.kernel, self.workdir,
+ self.initramfs, self.workdir)
+ subprocess.run(cmd.split())
+
+ def test_pseries(self):
+ """
+ :avocado: tags=machine:pseries
+ """
+ kernel=os.path.normpath(os.path.join(self.workdir, self.kernel))
+ initramfs=os.path.normpath(os.path.join(self.workdir, self.initramfs))
+ cmdline="root=UUID=8a409ee6-3cb3-4b06-a266-39e2dae3e5fa ro "
+ "no_timer_check net.ifnames=0 console=tty1 "
+ "console=ttyS0,115200n8"
+ self.run_rr(shift=1, args=("-device", "spapr-vscsi",
+ "-machine", "x-vof=on",
+ "-kernel", kernel,
+ "-initrd", initramfs,
+ "-append", cmdline))
--
2.42.0
- [PATCH 0/9] tests/avocado: ppc additions and other fixes, Nicholas Piggin, 2024/01/07
- [PATCH 1/9] gitlab: fix s390x tag for avocado-system-centos, Nicholas Piggin, 2024/01/07
- [PATCH 2/9] tests/avocado: mark boot_linux.py long runtime instead of flaky, Nicholas Piggin, 2024/01/07
- [PATCH 3/9] tests/avocado: Mark x86-64 boot_linux.py TCG tests as long runtime, Nicholas Piggin, 2024/01/07
- [PATCH 4/9] tests/avocado: Enable replay_linux.py on ppc64 pseries,
Nicholas Piggin <=
- [PATCH 5/9] tests/avocado: ppc add powernv10 boot_linux_console test, Nicholas Piggin, 2024/01/07
- [PATCH 6/9] tests/avocado: Add ppc pseries and powernv hash MMU tests, Nicholas Piggin, 2024/01/07
- [PATCH 7/9] tests/avocado: Add pseries KVM boot_linux test, Nicholas Piggin, 2024/01/07
- [PATCH 8/9] tests/avocado: ppc add hypervisor tests, Nicholas Piggin, 2024/01/07
- [PATCH 9/9] tests/avocado: Add FreeBSD distro boot tests for ppc, Nicholas Piggin, 2024/01/07