qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 22/22] target/i386: implement CMPccXADD


From: Richard Henderson
Subject: Re: [PATCH 22/22] target/i386: implement CMPccXADD
Date: Fri, 29 Dec 2023 10:04:06 +1100
User-agent: Mozilla Thunderbird

On 12/23/23 05:16, Paolo Bonzini wrote:
+    case JCC_S:
+        cmp_lhs = s->T0, cmp_rhs = tcg_constant_tl(0);
+        break;

I think you need an sextract here, when ot != full word size, same as JCC_O.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]