[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/21] parallels: Limit search in parallels_mark_used to the l
From: |
Alexander Ivanov |
Subject: |
[PATCH v4 04/21] parallels: Limit search in parallels_mark_used to the last marked claster |
Date: |
Thu, 28 Dec 2023 11:12:15 +0100 |
There is no necessity to search to the end of the bitmap. Limit the search
area as cluster_index + count.
Add cluster_end variable to avoid its calculation in a few places.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index ae524f1820..4470519656 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -182,13 +182,14 @@ int parallels_mark_used(BlockDriverState *bs, unsigned
long *bitmap,
uint32_t bitmap_size, int64_t off, uint32_t count)
{
BDRVParallelsState *s = bs->opaque;
- uint32_t cluster_index = host_cluster_index(s, off);
+ uint32_t cluster_end, cluster_index = host_cluster_index(s, off);
unsigned long next_used;
- if (cluster_index + count > bitmap_size) {
+ cluster_end = cluster_index + count;
+ if (cluster_end > bitmap_size) {
return -E2BIG;
}
- next_used = find_next_bit(bitmap, bitmap_size, cluster_index);
- if (next_used < cluster_index + count) {
+ next_used = find_next_bit(bitmap, cluster_end, cluster_index);
+ if (next_used < cluster_end) {
return -EBUSY;
}
bitmap_set(bitmap, cluster_index, count);
--
2.40.1
- [PATCH v4 00/21] parallels: Add full dirty bitmap support, Alexander Ivanov, 2023/12/28
- [PATCH v4 01/21] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2023/12/28
- [PATCH v4 03/21] parallels: Make mark_used() a global function, Alexander Ivanov, 2023/12/28
- [PATCH v4 02/21] parallels: Move inactivation code to a separate function, Alexander Ivanov, 2023/12/28
- [PATCH v4 04/21] parallels: Limit search in parallels_mark_used to the last marked claster,
Alexander Ivanov <=
- [PATCH v4 14/21] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/12/28
- [PATCH v4 16/21] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/12/28
- [PATCH v4 17/21] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2023/12/28
- [PATCH v4 18/21] parallels: Remove unnecessary data_end field, Alexander Ivanov, 2023/12/28
- [PATCH v4 05/21] parallels: Add parallels_mark_unused() helper, Alexander Ivanov, 2023/12/28
- [PATCH v4 07/21] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/12/28
- [PATCH v4 06/21] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/12/28
- [PATCH v4 15/21] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/12/28
- [PATCH v4 09/21] parallels: Add a note about used bitmap in parallels_check_duplicate(), Alexander Ivanov, 2023/12/28
- [PATCH v4 11/21] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/12/28