[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/21] parallels: Add a note about used bitmap in parallels_check
From: |
Alexander Ivanov |
Subject: |
[PATCH 09/21] parallels: Add a note about used bitmap in parallels_check_duplicate() |
Date: |
Thu, 28 Dec 2023 10:41:41 +0100 |
In parallels_check_duplicate() We use a bitmap for duplication detection.
This bitmap is not related to used_bmap field in BDRVParallelsState. Add
a comment about it to avoid confusion.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 04c114f696..0ae06ec0b1 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -837,7 +837,10 @@ parallels_check_duplicate(BlockDriverState *bs,
BdrvCheckResult *res,
bool fixed = false;
/*
- * Create a bitmap of used clusters.
+ * Create a bitmap of used clusters. Please note that this bitmap is not
+ * related to used_bmap field in BDRVParallelsState and is created only for
+ * local usage.
+ *
* If a bit is set, there is a BAT entry pointing to this cluster.
* Loop through the BAT entries, check bits relevant to an entry offset.
* If bit is set, this entry is duplicated. Otherwise set the bit.
--
2.40.1
- [PATCH 06/21] parallels: Move host clusters allocation to a separate function, (continued)
- [PATCH 06/21] parallels: Move host clusters allocation to a separate function, Alexander Ivanov, 2023/12/28
- [PATCH 07/21] parallels: Set data_end value in parallels_check_leak(), Alexander Ivanov, 2023/12/28
- [PATCH 11/21] parallels: Add dirty bitmaps saving, Alexander Ivanov, 2023/12/28
- [PATCH 10/21] parallels: Create used bitmap even if checks needed, Alexander Ivanov, 2023/12/28
- [PATCH 08/21] parallels: Recreate used bitmap in parallels_check_leak(), Alexander Ivanov, 2023/12/28
- [PATCH 12/21] parallels: Let image extensions work in RW mode, Alexander Ivanov, 2023/12/28
- [PATCH 13/21] parallels: Handle L1 entries equal to one, Alexander Ivanov, 2023/12/28
- [PATCH 17/21] parallels: Check unused clusters in parallels_check_leak(), Alexander Ivanov, 2023/12/28
- [PATCH 20/21] tests: Turned on 256, 299, 304 and block-status-cache for parallels format, Alexander Ivanov, 2023/12/28
- [PATCH 21/21] tests: Add parallels format support to image-fleecing, Alexander Ivanov, 2023/12/28
- [PATCH 09/21] parallels: Add a note about used bitmap in parallels_check_duplicate(),
Alexander Ivanov <=
- [PATCH 15/21] parallels: Reverse a conditional in parallels_check_leak() to reduce indents, Alexander Ivanov, 2023/12/28
- [PATCH 14/21] parallels: Make a loaded dirty bitmap persistent, Alexander Ivanov, 2023/12/28
- [PATCH 18/21] parallels: Remove unnecessary data_end field, Alexander Ivanov, 2023/12/28
- [PATCH 19/21] tests: Add parallels images support to test 165, Alexander Ivanov, 2023/12/28
- [PATCH 16/21] parallels: Truncate images on the last used cluster, Alexander Ivanov, 2023/12/28
- [PATCH 03/21] parallels: Make mark_used() a global function, Alexander Ivanov, 2023/12/28
- Re: [PATCH 01/21] parallels: Set s->used_bmap to NULL in parallels_free_used_bitmap(), Alexander Ivanov, 2023/12/28