Re: [PATCH v3 04/17] hw/loongarch: Add init_cmdline

[gaosong]

在 2023/12/27 下午4:49, Philippe Mathieu-Daudé 写道:
> Hi,
>
> On 27/12/23 09:08, Song Gao wrote:
> > Add init_cmline and set boot_info->a0, a1
> >
> > Signed-off-by: Song Gao <gaosong@loongson.cn>
> > ---
> >   hw/loongarch/boot.c    | 20 ++++++++++++++++++++
> >   target/loongarch/cpu.h |  2 ++
> >   2 files changed, 22 insertions(+)
> >
> > diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c
> > index faff880153..27eae6f0cb 100644
> > --- a/hw/loongarch/boot.c
> > +++ b/hw/loongarch/boot.c
> > @@ -13,6 +13,7 @@
> >   #include "elf.h"
> >   #include "qemu/error-report.h"
> >   #include "sysemu/reset.h"
> > +#include <asm-generic/setup.h>
>
> Build failure on Darwin host:
>
> [1135/1207] Compiling C object 
> libqemu-loongarch64-softmmu.fa.p/hw_loongarch_boot.c.o
> FAILED: libqemu-loongarch64-softmmu.fa.p/hw_loongarch_boot.c.o
> ../../hw/loongarch/boot.c:16:10: fatal error: 'asm-generic/setup.h' 
> file not found
> #include <asm-generic/setup.h>
>          ^~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> ninja: build stopped: subcommand failed.
I will drop it , use #define COMAND_LINE_SIZE  512.

Thanks.
Song Gao