|
From: | Richard Henderson |
Subject: | Re: [PATCH 25/35] target/arm: Handle FEAT_NV2 redirection of SPSR_EL2, ELR_EL2, ESR_EL2, FAR_EL2 |
Date: | Thu, 28 Dec 2023 10:11:45 +1100 |
User-agent: | Mozilla Thunderbird |
On 12/18/23 22:32, Peter Maydell wrote:
@@ -2173,7 +2174,14 @@ static void handle_sys(DisasContext *s, bool isread, * for registers accessible at EL1). */ skip_fp_access_checks = true; - if (s->nv && arm_cpreg_traps_in_nv(ri)) { + if (s->nv && s->nv2 && (ri->type & ARM_CP_NV2_REDIRECT)) {
You've documented and implemented that nv2 is true iff nv, thus the nv test can be dropped. Otherwise, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |