[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 18/21] vdpa: move iommu_list to vhost_vdpa_shared
From: |
Michael S. Tsirkin |
Subject: |
[PULL 18/21] vdpa: move iommu_list to vhost_vdpa_shared |
Date: |
Tue, 26 Dec 2023 04:25:13 -0500 |
From: Eugenio Pérez <eperezma@redhat.com>
Next patches will register the vhost_vdpa memory listener while the VM
is migrating at the destination, so we can map the memory to the device
before stopping the VM at the source. The main goal is to reduce the
downtime.
However, the destination QEMU is unaware of which vhost_vdpa device will
register its memory_listener. If the source guest has CVQ enabled, it
will be the CVQ device. Otherwise, it will be the first one.
Move the iommu_list member to VhostVDPAShared so all vhost_vdpa can use
it, rather than always in the first / last vhost_vdpa.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20231221174322.3130442-11-eperezma@redhat.com>
Tested-by: Lei Yang <leiyang@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/virtio/vhost-vdpa.h | 2 +-
hw/virtio/vhost-vdpa.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 5bd964dac5..3880b9e7f2 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -34,6 +34,7 @@ typedef struct VhostVDPAHostNotifier {
typedef struct vhost_vdpa_shared {
int device_fd;
struct vhost_vdpa_iova_range iova_range;
+ QLIST_HEAD(, vdpa_iommu) iommu_list;
/* IOVA mapping used by the Shadow Virtqueue */
VhostIOVATree *iova_tree;
@@ -62,7 +63,6 @@ typedef struct vhost_vdpa {
struct vhost_dev *dev;
Error *migration_blocker;
VhostVDPAHostNotifier notifier[VIRTIO_QUEUE_MAX];
- QLIST_HEAD(, vdpa_iommu) iommu_list;
IOMMUNotifier n;
} VhostVDPA;
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index cbfcf18883..a2713b9f0b 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -279,7 +279,7 @@ static void vhost_vdpa_iommu_region_add(MemoryListener
*listener,
return;
}
- QLIST_INSERT_HEAD(&v->iommu_list, iommu, iommu_next);
+ QLIST_INSERT_HEAD(&v->shared->iommu_list, iommu, iommu_next);
memory_region_iommu_replay(iommu->iommu_mr, &iommu->n);
return;
@@ -292,7 +292,7 @@ static void vhost_vdpa_iommu_region_del(MemoryListener
*listener,
struct vdpa_iommu *iommu;
- QLIST_FOREACH(iommu, &v->iommu_list, iommu_next)
+ QLIST_FOREACH(iommu, &v->shared->iommu_list, iommu_next)
{
if (MEMORY_REGION(iommu->iommu_mr) == section->mr &&
iommu->n.start == section->offset_within_region) {
--
MST
- [PULL 08/21] vdpa: do not set virtio status bits if unneeded, (continued)
- [PULL 08/21] vdpa: do not set virtio status bits if unneeded, Michael S. Tsirkin, 2023/12/26
- [PULL 09/21] vdpa: add VhostVDPAShared, Michael S. Tsirkin, 2023/12/26
- [PULL 10/21] vdpa: move iova tree to the shared struct, Michael S. Tsirkin, 2023/12/26
- [PULL 11/21] vdpa: move iova_range to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 12/21] vdpa: move shadow_data to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 13/21] vdpa: use vdpa shared for tracing, Michael S. Tsirkin, 2023/12/26
- [PULL 14/21] vdpa: move file descriptor to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 15/21] vdpa: move iotlb_batch_begin_sent to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 16/21] vdpa: move backend_cap to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 17/21] vdpa: remove msg type of vhost_vdpa, Michael S. Tsirkin, 2023/12/26
- [PULL 18/21] vdpa: move iommu_list to vhost_vdpa_shared,
Michael S. Tsirkin <=
- [PULL 19/21] vdpa: use VhostVDPAShared in vdpa_dma_map and unmap, Michael S. Tsirkin, 2023/12/26
- [PULL 20/21] vdpa: use dev_shared in vdpa_iommu, Michael S. Tsirkin, 2023/12/26
- [PULL 21/21] vdpa: move memory listener to vhost_vdpa_shared, Michael S. Tsirkin, 2023/12/26
- [PULL 06/21] vhost-scsi: fix usage of error_reportf_err(), Michael S. Tsirkin, 2023/12/26
- Re: [PULL 00/21] virtio,pc,pci: features, cleanups, fixes, Michael S. Tsirkin, 2023/12/26
- Re: [PULL 00/21] virtio,pc,pci: features, cleanups, fixes, Stefan Hajnoczi, 2023/12/26