[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/24] target/ppc/excp_helper: Avoid 'abi_ptr' in system emul
From: |
Nicholas Piggin |
Subject: |
Re: [PATCH 17/24] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation |
Date: |
Fri, 22 Dec 2023 14:37:42 +1000 |
On Tue Dec 12, 2023 at 7:19 AM AEST, Philippe Mathieu-Daudé wrote:
> 'abi_ptr' is a user specific type. The system emulation
> equivalent is 'target_ulong'. Use it in ppc_ldl_code()
> to emphasis this is not an user emulation function.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> target/ppc/excp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index a42743a3e0..3d7c9bbf1a 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -142,7 +142,7 @@ static inline bool insn_need_byteswap(CPUArchState *env)
> return !!(env->msr & ((target_ulong)1 << MSR_LE));
> }
>
> -static uint32_t ppc_ldl_code(CPUArchState *env, abi_ptr addr)
> +static uint32_t ppc_ldl_code(CPUArchState *env, target_ulong addr)
> {
> uint32_t insn = cpu_ldl_code(env, addr);
>
- [PATCH 14/24] gdbstub: Include missing 'hw/core/cpu.h' header, (continued)
- [PATCH 14/24] gdbstub: Include missing 'hw/core/cpu.h' header, Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 13/24] accel/tcg: Include missing 'hw/core/cpu.h' header, Philippe Mathieu-Daudé, 2023/12/11
- Re: [PATCH 00/24] exec: Rework of various headers (user focused), Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 15/24] exec/cpu-all: Remove unused headers, Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 16/24] exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion, Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 17/24] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation, Philippe Mathieu-Daudé, 2023/12/11
- Re: [PATCH 17/24] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation,
Nicholas Piggin <=
- [PATCH 18/24] accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h', Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 19/24] exec/user: Do not include 'cpu.h' in 'abitypes.h', Philippe Mathieu-Daudé, 2023/12/11
- [PATCH 20/24] exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h' header, Philippe Mathieu-Daudé, 2023/12/11