[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/21] configure: remove unnecessary subshell
From: |
Paolo Bonzini |
Subject: |
[PATCH 05/21] configure: remove unnecessary subshell |
Date: |
Thu, 21 Dec 2023 18:19:42 +0100 |
Do not use a subshell to hide the shadowing of $config_host_mak.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 6ea8f53310e..c634948051b 100755
--- a/configure
+++ b/configure
@@ -1671,10 +1671,9 @@ if test "$targetos" = windows; then
fi
# tests/tcg configuration
-(config_host_mak=tests/tcg/config-host.mak
mkdir -p tests/tcg
-echo "# Automatically generated by configure - do not modify" >
$config_host_mak
-echo "SRC_PATH=$source_path" >> $config_host_mak
+echo "# Automatically generated by configure - do not modify" >
tests/tcg/$config_host_mak
+echo "SRC_PATH=$source_path" >> tests/tcg/$config_host_mak
tcg_tests_targets=
for target in $target_list; do
@@ -1717,9 +1716,8 @@ for target in $target_list; do
done
if test "$tcg" = "enabled"; then
- echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> config-host.mak
+ echo "TCG_TESTS_TARGETS=$tcg_tests_targets" >> $config_host_mak
fi
-)
if test "$skip_meson" = no; then
cross="config-meson.cross.new"
--
2.43.0
- [PATCH 00/21] Build system cleanups for QEMU 9.0, Paolo Bonzini, 2023/12/21
- [PATCH 01/21] meson: fix type of "relocatable" option, Paolo Bonzini, 2023/12/21
- [PATCH 03/21] meson: use version_compare() to compare version, Paolo Bonzini, 2023/12/21
- [PATCH 04/21] Makefile: clean qemu-iotests output, Paolo Bonzini, 2023/12/21
- [PATCH 05/21] configure: remove unnecessary subshell,
Paolo Bonzini <=
- [PATCH 06/21] configure: unify again the case arms in probe_target_compiler, Paolo Bonzini, 2023/12/21
- [PATCH 07/21] meson: always probe u2f and canokey if the option is enabled, Paolo Bonzini, 2023/12/21
- [PATCH 02/21] meson: remove unused variable, Paolo Bonzini, 2023/12/21
- [PATCH 08/21] meson: remove OS definitions from config_targetos, Paolo Bonzini, 2023/12/21
- [PATCH 09/21] meson: remove CONFIG_POSIX and CONFIG_WIN32 from config_targetos, Paolo Bonzini, 2023/12/21
- [PATCH 10/21] meson: remove config_targetos, Paolo Bonzini, 2023/12/21
- [PATCH 11/21] meson: remove CONFIG_ALL, Paolo Bonzini, 2023/12/21