[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/2] hw/s390x/ccw: Cleanup basename() and dirname()
From: |
Zhao Liu |
Subject: |
[PATCH 0/2] hw/s390x/ccw: Cleanup basename() and dirname() |
Date: |
Fri, 22 Dec 2023 01:19:19 +0800 |
From: Zhao Liu <zhao1.liu@intel.com>
As commit 3e015d815b3f ("use g_path_get_basename instead of basename")
said, g_path_get_basename() and g_path_get_dirname() should be preferred
over basename() and dirname(), since g_path_get_basename() and
g_path_get_dirname() are portable utility functions that have the
advantage of not modifing the string argument.
But commit 3e015d815b3f missed a use of dirname() and basename() in
hw/s390x/ccw.
And basename() (in vfio/container) caused compile breakage with the Musl
C library [1].
To avoid similar breakage and improve portability, replace basename()
and dirname() with g_path_get_basename() and g_path_get_dirname().
[1]: 20231212010228.2701544-1-raj.khem@gmail.com/">https://lore.kernel.org/all/20231212010228.2701544-1-raj.khem@gmail.com/
---
Zhao Liu (2):
hw/s390x/ccw: Replace basename() with g_path_get_basename()
hw/s390x/ccw: Replace dirname() with g_path_get_dirname()
hw/s390x/s390-ccw.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.34.1
- [PATCH 0/2] hw/s390x/ccw: Cleanup basename() and dirname(),
Zhao Liu <=