qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices


From: Samuel Tardieu
Subject: Re: [PATCH 0/3] Add "num-prio-bits" property for Cortex-M devices
Date: Tue, 19 Dec 2023 20:13:52 +0100
User-agent: mu4e 1.10.8; emacs 29.1


Peter Maydell <peter.maydell@linaro.org> writes:

Any idea to why patchew fails to apply thoses patches? The mbox at
<20231216182740.3305724-1-sam@rfc1149.net/">https://patchew.org/QEMU/20231216182740.3305724-1-sam@rfc1149.net/>
applies cleanly on master AFAICS.

This is because you put a Based-on: tag in the cover letter.
Based-on: means "please apply this other patch first before this
series, because there is a dependency" (we use it for things
like "this patchset has to sit on top of some other cleanup
patchset I sent last week and which hasn't got into git yet").
So patchew applied Anton's original patch from 2022, and then tried to apply your three patches on top of that, which caused a conflict.

Thanks for the explanation. I thought "Based-on:" was just a polite way of attributing credit to past discussions. I'll keep that in mind. Do you want me to resubmit it as a v2 without the "Based-on:" tag so that patchew gets it right?

Anyway, I just wanted to say that this patchset is on my
todo list to review but I'm not going to be able to get to
it before I break for Christmas, so I'll get back to it
in January. Thanks for the contribution!

Noted!

Best.

 Sam
--
Samuel Tardieu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]