Re: [PATCH v2] string-output-visitor: show structs as "<omitted>"

[Stefan Hajnoczi]

On Tue, 19 Dec 2023 at 09:49, Markus Armbruster <armbru@redhat.com> wrote:
>
> Stefan Hajnoczi <stefanha@redhat.com> writes:
>
> > StringOutputVisitor crashes when it visits a struct because
> > ->start_struct() is NULL.
> >
> > Show "<omitted>" instead of crashing. This is necessary because the
> > virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce
> > soon is a list of IOThreadMapping structs.
> >
> > This patch is a quick fix to solve the crash, but the long-term solution
> > is replacing StringOutputVisitor with something that can handle the full
> > gamut of values in QEMU.
> >
> > Cc: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Okay as a stopgap to unblock your virtio-blk-pci work.  Suggest you
> merge this patch together with the patch that needs it.

Thanks!

Stefan