[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2 2/4] crypto: Introduce payload offset set function
From: |
Daniel P . Berrangé |
Subject: |
Re: [v2 2/4] crypto: Introduce payload offset set function |
Date: |
Mon, 18 Dec 2023 11:16:53 +0000 |
User-agent: |
Mutt/2.2.10 (2023-03-25) |
On Thu, Dec 07, 2023 at 12:37:43AM +0800, Hyman Huang wrote:
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
> ---
> crypto/block.c | 4 ++++
> include/crypto/block.h | 1 +
> 2 files changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
however, based on my comment in patch #3, I'm not convinced this method
is needed
>
> diff --git a/crypto/block.c b/crypto/block.c
> index 7bb4b74a37..3dcf22a69f 100644
> --- a/crypto/block.c
> +++ b/crypto/block.c
> @@ -319,6 +319,10 @@ QCryptoHashAlgorithm
> qcrypto_block_get_kdf_hash(QCryptoBlock *block)
> return block->kdfhash;
> }
>
> +void qcrypto_block_set_payload_offset(QCryptoBlock *block, uint64_t offset)
> +{
> + block->payload_offset = offset;
> +}
>
> uint64_t qcrypto_block_get_payload_offset(QCryptoBlock *block)
> {
> diff --git a/include/crypto/block.h b/include/crypto/block.h
> index 4f63a37872..b47a90c529 100644
> --- a/include/crypto/block.h
> +++ b/include/crypto/block.h
> @@ -312,4 +312,5 @@ void qcrypto_block_free(QCryptoBlock *block);
>
> G_DEFINE_AUTOPTR_CLEANUP_FUNC(QCryptoBlock, qcrypto_block_free)
>
> +void qcrypto_block_set_payload_offset(QCryptoBlock *block, uint64_t offset);
> #endif /* QCRYPTO_BLOCK_H */
> --
> 2.39.1
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|