|
From: | Akihiko Odaki |
Subject: | Re: [PATCH v3 1/3] Move dbus-display1 out of ui |
Date: | Sun, 17 Dec 2023 15:14:18 +0900 |
User-agent: | Mozilla Thunderbird |
On 2023/12/17 1:57, Philippe Mathieu-Daudé wrote:
On 16/12/23 08:53, Akihiko Odaki wrote:Despite its name, dbus-display1 does not only provide DBus interfaces for the display but also for the audio. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- MAINTAINERS | 1 + meson.build | 21 +++++++++++++++++++++ ui/dbus.h | 2 +- audio/dbusaudio.c | 2 +- tests/qtest/dbus-display-test.c | 2 +- ui/dbus-display1.xml => dbus-display1.xml | 0What about moving it to backends/ instead? Also could be renamed. "ui" means User Interface. Audio is still one. Suggestions: ui/dbus-backend, backends/dbus-... ?
Moved to util with v4 as I'm adding it to libqemuutil for dbus-display-test. (And I sent v5 since I missed to update the documentation; sorry for sending changes so frequently.)
The file name represents the D-Bus interface name, and renaming the D-Bus interface name will be a breaking change so I decided not to do that for now.
[Prev in Thread] | Current Thread | [Next in Thread] |