qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6] ui/cocoa: Use NSWindow's ability to resize


From: Marek Glogowski
Subject: Re: [PATCH v6] ui/cocoa: Use NSWindow's ability to resize
Date: Sat, 16 Dec 2023 23:40:54 +0100

Hi

I think I may have found a small error 
 
>     if (opts->u.cocoa.has_zoom_to_fit && opts->u.cocoa.zoom_to_fit) {
+        [normalWindow setStyleMask:[normalWindow styleMask] & 
~NSWindowStyleMaskResizable];

it should probably be so, because the window never goes into a good mode 
 [normalWindow setStyleMask:[normalWindow styleMask] | 
NSWindowStyleMaskResizable];
 
and the zoom to fit option will never be checked end enable

  menuItem = [[[NSMenuItem alloc] initWithTitle:@"Zoom To Fit" 
action:@selector(zoomToFit:) keyEquivalent:@""] autorelease];
 [menuItem setState: [normalWindow styleMask] & NSWindowStyleMaskResizable ? 
NSControlStateValueOn : NSControlStateValueOff];


reply via email to

[Prev in Thread] Current Thread [Next in Thread]