qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 17/35] tcg/mips: Support TCG_COND_TST{EQ,NE}


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 17/35] tcg/mips: Support TCG_COND_TST{EQ,NE}
Date: Wed, 13 Dec 2023 15:06:17 +0100
User-agent: Mozilla Thunderbird

Hi Richard,

On 17/11/23 17:36, Richard Henderson wrote:
On 11/16/23 23:46, Philippe Mathieu-Daudé wrote:
Hi Richard,

On 28/10/23 21:45, Richard Henderson wrote:
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  tcg/mips/tcg-target.c.inc | 41 +++++++++++++++++++++++++++++++++++++++
  1 file changed, 41 insertions(+)


@@ -1053,6 +1071,14 @@ static void tcg_out_setcond2(TCGContext *s, TCGCond cond, TCGReg ret,
          tcg_out_setcond(s, cond, ret, tmp1, TCG_REG_ZERO);
          break;
+    case TCG_COND_TSTEQ:
+    case TCG_COND_TSTNE:
+        tcg_out_opc_reg(s, OPC_AND, TCG_TMP0, al, bl);
+        tcg_out_opc_reg(s, OPC_AND, TCG_TMP1, ah, bh);
+        tcg_out_opc_reg(s, OPC_OR, ret, TCG_TMP0, TCG_TMP1);
+        tcg_out_setcond(s, tcg_eqne_cond(cond), ret, tmp1, TCG_REG_ZERO);

Where is tcg_eqne_cond() declared?

tcg_tst_eqne_cond() is in tcg/tcg-cond.h.
This is a rebase error when I renamed it; I have fixed it since.

Looking at https://gitlab.com/rth7680/qemu/-/commits/tcg-test/
commits the patch is now quite different. I suppose you plan to
post a v3, so will wait for it to finish what isn't reviewed.

Regards,

Phil.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]