[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/23] semihosting/guestfd: Remove unused 'semihosting/uac
From: |
Anton Johansson |
Subject: |
Re: [PATCH v2 07/23] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header |
Date: |
Wed, 13 Dec 2023 11:58:55 +0100 |
On 12/12/23, Philippe Mathieu-Daudé wrote:
> Nothing in guestfd.c requires "semihosting/uaccess.h" nor "qemu.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> semihosting/guestfd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c
> index 955c2efbd0..d3241434c5 100644
> --- a/semihosting/guestfd.c
> +++ b/semihosting/guestfd.c
> @@ -12,10 +12,7 @@
> #include "gdbstub/syscalls.h"
> #include "semihosting/semihost.h"
> #include "semihosting/guestfd.h"
> -#ifdef CONFIG_USER_ONLY
> -#include "qemu.h"
> -#else
> -#include "semihosting/uaccess.h"
> +#ifndef CONFIG_USER_ONLY
> #include CONFIG_DEVICES
> #endif
>
> --
> 2.41.0
>
Reviewed-by: Anton Johansson <anjo@rev.ng>
--
Anton Johansson
rev.ng Labs Srl.
- [PATCH v2 00/23] exec: Rework of various headers (user focused), Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 01/23] exec: Include 'cpu.h' before validating CPUArchState placement, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 02/23] exec: Expose 'target_page.h' API to user emulation, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 03/23] target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h', Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 04/23] accel: Include missing 'exec/cpu_ldst.h' header, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 06/23] semihosting/uaccess: Avoid including 'cpu.h', Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 07/23] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header, Philippe Mathieu-Daudé, 2023/12/12
- Re: [PATCH v2 07/23] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header,
Anton Johansson <=
- [PATCH v2 05/23] gdbstub: Include missing 'hw/core/cpu.h' header, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 09/23] host/atomic128: Include missing 'qemu/atomic.h' header, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 08/23] host/load-extract: Include missing 'qemu/atomic.h' and 'qemu/int128.h', Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 10/23] target/i386: Include missing 'exec/exec-all.h' header, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 11/23] accel/tcg: Include missing 'hw/core/cpu.h' header, Philippe Mathieu-Daudé, 2023/12/12
- [PATCH v2 12/23] exec/cpu-all: Remove unused 'qemu/thread.h' header, Philippe Mathieu-Daudé, 2023/12/12