[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 1/5] ebpf: Added eBPF map update through mmap.
From: |
Jason Wang |
Subject: |
Re: [PATCH v7 1/5] ebpf: Added eBPF map update through mmap. |
Date: |
Tue, 12 Dec 2023 11:35:12 +0800 |
On Mon, Dec 11, 2023 at 10:07 PM Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> On 2023/12/11 22:48, Yuri Benditovich wrote:
> > Akihiko,
> > This series was already discussed several months ago.
> > I'd suggest to postpone commenting on it and resume them after merging.
>
> I found a pull request:
> https://lore.kernel.org/all/20230908064507.14596-14-jasowang@redhat.com/
>
> Strangely patches from that series seem missed although earlier patches
> are on the tree. Jason, can you tell what's going on?
It should be my bad. eBPF RSS series were in V1 of the PULL request
but missed accidentally in V2.
>
> In any case, I wrote comments to the patch series. Andrew, can you check
> them? They are mostly nitpicks, but I think you may have a look at
> DEFINE_PROP_ARRAY(); it may make it easier to implement the libvirt side.
>
> I also forgot to say that properties should not have underscores;
> ebpf_rss_fds should be ebpf-rss-fds. See:
> https://gitlab.com/qemu-project/qemu/-/blob/master/include/qom/object.h?ref_type=heads#L1013
>
> The series needs to be rebased too, but probably it's better off to wait
> Jason to figure out the current situation of the series. Once it gets
> all sorted out, I'll rebase my series on top of it and ask for review.
Great, the pull request will be soon when 8.2 is released.
Thanks
>
> Regards,
> Akihiko Odaki
>