qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 20/24] exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h'


From: Richard Henderson
Subject: Re: [PATCH 20/24] exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h' header
Date: Mon, 11 Dec 2023 17:18:24 -0800
User-agent: Mozilla Thunderbird

On 12/11/23 13:19, Philippe Mathieu-Daudé wrote:
The abi_ptr type is declared in "exec/cpu_ldst.h" with all
the load/store helpers. Some source files requiring abi_ptr
type don't need the load/store helpers. In order to simplify,
create a new "tcg/abi_ptr.h" header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  include/exec/cpu_ldst.h   | 17 +++--------------
  include/exec/exec-all.h   |  1 +
  include/exec/translator.h |  5 ++++-
  include/tcg/abi_ptr.h     | 32 ++++++++++++++++++++++++++++++++
  accel/tcg/cputlb.c        |  1 +
  5 files changed, 41 insertions(+), 15 deletions(-)
  create mode 100644 include/tcg/abi_ptr.h

I'm unconvinced about this being tcg related, per se.
Leave it in include/exec/, with exec/user/abitypes.h.

With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]