Re: [PATCH v3 4/4] accel/tcg: Move perf and debuginfo support to tcg

[Richard Henderson]

On 12/7/23 16:35, Ilya Leoshkevich wrote:
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -63,7 +63,7 @@
>   #include "tb-context.h"
>   #include "internal-common.h"
>   #include "internal-target.h"
> -#include "perf.h"
> +#include "tcg/perf.h"
>   #include "tcg/insn-start-words.h"

Because this header is used outside of tcg/, the header should be 
include/tcg/perf.h.

> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index e7a9b3775bb..b8e52f3fb0f 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -62,7 +62,7 @@
>   #include "hw/boards.h"
>   #include "qemu/cutils.h"
>   #include "sysemu/runstate.h"
> -#include "accel/tcg/debuginfo.h"
> +#include "tcg/debuginfo.h"
>   
>   #include <zlib.h>
>   
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index cf9e74468b1..62120c76151 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -21,7 +21,7 @@
>   #include "qapi/error.h"
>   #include "qemu/error-report.h"
>   #include "target_signal.h"
> -#include "accel/tcg/debuginfo.h"
> +#include "tcg/debuginfo.h"
>   
>   #ifdef TARGET_ARM
>   #include "target/arm/cpu-features.h"

Likewise.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~