[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 14/16] accel/tcg: define tlb_fill as a trace point
From: |
Alex Bennée |
Subject: |
[PATCH v2 14/16] accel/tcg: define tlb_fill as a trace point |
Date: |
Mon, 11 Dec 2023 09:13:43 +0000 |
While we do have a bunch of debugging we can turn on in cputlb there
is an argument for making tlb_fill a generally available trace point.
Any fault (via probe or access) will have to be preceded by a tlb_fill
for the address in question.
We don't bother logging the return address as that will be a host
address associated with translation and therefor can move around with
ASLR.
In my particular case I'm trying to track down a difference in memory
fault exception patterns between record and replay phases.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
accel/tcg/cputlb.c | 2 ++
accel/tcg/trace-events | 1 +
2 files changed, 3 insertions(+)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index db3f93fda9..c35df27caf 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1308,6 +1308,8 @@ static void tlb_fill(CPUState *cpu, vaddr addr, int size,
{
bool ok;
+ trace_tlb_fill(addr, size, access_type, mmu_idx);
+
/*
* This is not a probe, so only valid return is success; failure
* should result in exception + longjmp to the cpu loop.
diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events
index 4e9b450520..31dda01c12 100644
--- a/accel/tcg/trace-events
+++ b/accel/tcg/trace-events
@@ -9,6 +9,7 @@ exec_tb_exit(void *last_tb, unsigned int flags) "tb:%p
flags=0x%x"
# cputlb.c
memory_notdirty_write_access(uint64_t vaddr, uint64_t ram_addr, unsigned size)
"0x%" PRIx64 " ram_addr 0x%" PRIx64 " size %u"
memory_notdirty_set_dirty(uint64_t vaddr) "0x%" PRIx64
+tlb_fill(uint64_t vaddr, int size, int access_type, int mmu_idx) "0x%" PRIx64
"/%d %d %d"
# translate-all.c
translate_block(void *tb, uintptr_t pc, const void *tb_code) "tb:%p,
pc:0x%"PRIxPTR", tb_code:%p"
--
2.39.2
- [PATCH v2 03/16] tests/avocado: modernise the drive args for replay_linux, (continued)
- [PATCH v2 03/16] tests/avocado: modernise the drive args for replay_linux, Alex Bennée, 2023/12/11
- [PATCH v2 05/16] scripts/replay_dump: track total number of instructions, Alex Bennée, 2023/12/11
- [PATCH v2 07/16] replay: add proper kdoc for ReplayState, Alex Bennée, 2023/12/11
- [PATCH v2 09/16] replay: introduce a central report point for sync errors, Alex Bennée, 2023/12/11
- [PATCH v2 06/16] replay: remove host_clock_last, Alex Bennée, 2023/12/11
- [PATCH v2 10/16] replay/replay-char: use report_sync_error, Alex Bennée, 2023/12/11
- [PATCH v2 08/16] replay: make has_unread_data a bool, Alex Bennée, 2023/12/11
- [PATCH v2 11/16] replay: stop us hanging in rr_wait_io_event, Alex Bennée, 2023/12/11
- [PATCH v2 14/16] accel/tcg: define tlb_fill as a trace point,
Alex Bennée <=
- [PATCH v2 15/16] accel/tcg: add trace_tlb_resize trace point, Alex Bennée, 2023/12/11
- [PATCH v2 16/16] replay: report sync error when no exception in log (!DEBUG INVESTIGATION), Alex Bennée, 2023/12/11
- [PATCH v2 13/16] tests/avocado: remove skips from replay_kernel, Alex Bennée, 2023/12/11
- [PATCH v2 12/16] chardev: force write all when recording replay logs, Alex Bennée, 2023/12/11
- Re: [PATCH v2 00/16] record/replay fixes: attempting to get avocado green, Alex Bennée, 2023/12/13