[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 08/16] replay: make has_unread_data a bool
From: |
Alex Bennée |
Subject: |
[PATCH v2 08/16] replay: make has_unread_data a bool |
Date: |
Mon, 11 Dec 2023 09:13:37 +0000 |
For clarity given it only has two states.
Message-Id: <20231205204106.95531-8-alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
replay/replay-internal.h | 4 ++--
replay/replay-internal.c | 4 ++--
replay/replay-snapshot.c | 6 +++---
replay/replay.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 98ca3748ed..1bc8fd5086 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -75,7 +75,7 @@ enum ReplayEvents {
* @current_icount: number of processed instructions
* @instruction_count: number of instructions until next event
* @data_kind: current event
- * @has_unread_data: 1 if event not yet processed
+ * @has_unread_data: true if event not yet processed
* @file_offset: offset into replay log at replay snapshot
* @block_request_id: current serialised block request id
* @read_event_id: current async read event id
@@ -85,7 +85,7 @@ typedef struct ReplayState {
uint64_t current_icount;
int instruction_count;
unsigned int data_kind;
- unsigned int has_unread_data;
+ bool has_unread_data;
uint64_t file_offset;
uint64_t block_request_id;
uint64_t read_event_id;
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index 77d0c82327..634025096e 100644
--- a/replay/replay-internal.c
+++ b/replay/replay-internal.c
@@ -179,7 +179,7 @@ void replay_fetch_data_kind(void)
replay_state.instruction_count = replay_get_dword();
}
replay_check_error();
- replay_state.has_unread_data = 1;
+ replay_state.has_unread_data = true;
if (replay_state.data_kind >= EVENT_COUNT) {
error_report("Replay: unknown event kind %d",
replay_state.data_kind);
@@ -191,7 +191,7 @@ void replay_fetch_data_kind(void)
void replay_finish_event(void)
{
- replay_state.has_unread_data = 0;
+ replay_state.has_unread_data = false;
replay_fetch_data_kind();
}
diff --git a/replay/replay-snapshot.c b/replay/replay-snapshot.c
index 10a7cf7992..bf75c2ed28 100644
--- a/replay/replay-snapshot.c
+++ b/replay/replay-snapshot.c
@@ -47,8 +47,8 @@ static int replay_post_load(void *opaque, int version_id)
static const VMStateDescription vmstate_replay = {
.name = "replay",
- .version_id = 2,
- .minimum_version_id = 2,
+ .version_id = 3,
+ .minimum_version_id = 3,
.pre_save = replay_pre_save,
.post_load = replay_post_load,
.fields = (VMStateField[]) {
@@ -56,7 +56,7 @@ static const VMStateDescription vmstate_replay = {
VMSTATE_UINT64(current_icount, ReplayState),
VMSTATE_INT32(instruction_count, ReplayState),
VMSTATE_UINT32(data_kind, ReplayState),
- VMSTATE_UINT32(has_unread_data, ReplayState),
+ VMSTATE_BOOL(has_unread_data, ReplayState),
VMSTATE_UINT64(file_offset, ReplayState),
VMSTATE_UINT64(block_request_id, ReplayState),
VMSTATE_UINT64(read_event_id, ReplayState),
diff --git a/replay/replay.c b/replay/replay.c
index 0f7d766efe..d729214197 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -258,7 +258,7 @@ static void replay_enable(const char *fname, int mode)
replay_state.data_kind = -1;
replay_state.instruction_count = 0;
replay_state.current_icount = 0;
- replay_state.has_unread_data = 0;
+ replay_state.has_unread_data = false;
/* skip file header for RECORD and check it for PLAY */
if (replay_mode == REPLAY_MODE_RECORD) {
--
2.39.2
- [PATCH v2 01/16] tests/avocado: add a simple i386 replay kernel test, (continued)
- [PATCH v2 01/16] tests/avocado: add a simple i386 replay kernel test, Alex Bennée, 2023/12/11
- [PATCH v2 02/16] tests/avocado: fix typo in replay_linux, Alex Bennée, 2023/12/11
- [PATCH v2 04/16] scripts/replay-dump: update to latest format, Alex Bennée, 2023/12/11
- [PATCH v2 03/16] tests/avocado: modernise the drive args for replay_linux, Alex Bennée, 2023/12/11
- [PATCH v2 05/16] scripts/replay_dump: track total number of instructions, Alex Bennée, 2023/12/11
- [PATCH v2 07/16] replay: add proper kdoc for ReplayState, Alex Bennée, 2023/12/11
- [PATCH v2 09/16] replay: introduce a central report point for sync errors, Alex Bennée, 2023/12/11
- [PATCH v2 06/16] replay: remove host_clock_last, Alex Bennée, 2023/12/11
- [PATCH v2 10/16] replay/replay-char: use report_sync_error, Alex Bennée, 2023/12/11
- [PATCH v2 08/16] replay: make has_unread_data a bool,
Alex Bennée <=
- [PATCH v2 11/16] replay: stop us hanging in rr_wait_io_event, Alex Bennée, 2023/12/11
- [PATCH v2 14/16] accel/tcg: define tlb_fill as a trace point, Alex Bennée, 2023/12/11
- [PATCH v2 15/16] accel/tcg: add trace_tlb_resize trace point, Alex Bennée, 2023/12/11
- [PATCH v2 16/16] replay: report sync error when no exception in log (!DEBUG INVESTIGATION), Alex Bennée, 2023/12/11
- [PATCH v2 13/16] tests/avocado: remove skips from replay_kernel, Alex Bennée, 2023/12/11