[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RFC v2 04/12] vfio: Avoid inspecting option QDict for rombar
From: |
Akihiko Odaki |
Subject: |
[PATCH RFC v2 04/12] vfio: Avoid inspecting option QDict for rombar |
Date: |
Sun, 10 Dec 2023 13:05:47 +0900 |
Use pci_rom_bar_explicitly_enabled() to determine if rombar is explicitly
enabled.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/vfio/pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index c62c02f7b6..bc29ce9194 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1008,7 +1008,6 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
{
uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
- DeviceState *dev = DEVICE(vdev);
char *name;
int fd = vdev->vbasedev.fd;
@@ -1042,7 +1041,7 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev)
}
if (vfio_opt_rom_in_denylist(vdev)) {
- if (dev->opts && qdict_haskey(dev->opts, "rombar")) {
+ if (pci_rom_bar_explicitly_enabled(&vdev->pdev)) {
warn_report("Device at %s is known to cause system instability"
" issues during option rom execution",
vdev->vbasedev.name);
--
2.43.0
- [PATCH RFC v2 00/12] virtio-net: add support for SR-IOV emulation, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 01/12] hw/pci: Initialize PCI multifunction after realization, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 02/12] hw/pci: Determine if rombar is explicitly enabled, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 03/12] hw/pci: Do not add ROM BAR for SR-IOV VF, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 04/12] vfio: Avoid inspecting option QDict for rombar,
Akihiko Odaki <=
- [PATCH RFC v2 05/12] hw/qdev: Remove opts member, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 06/12] pcie_sriov: Reuse SR-IOV VF device instances, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 07/12] pcie_sriov: Release VFs failed to realize, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 08/12] pcie_sriov: Ensure PF and VF are mutually exclusive, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 09/12] pcie_sriov: Check PCI Express for SR-IOV PF, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 10/12] pcie_sriov: Allow user to create SR-IOV device, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 11/12] virtio-pci: Implement SR-IOV PF, Akihiko Odaki, 2023/12/09
- [PATCH RFC v2 12/12] virtio-net: Implement SR-IOV VF, Akihiko Odaki, 2023/12/09