[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/10] tests/avocado: use more distinct names for assets
From: |
Cleber Rosa |
Subject: |
[PATCH 05/10] tests/avocado: use more distinct names for assets |
Date: |
Fri, 8 Dec 2023 14:09:06 -0500 |
Avocado's asset system will deposit files in a cache organized either
by their original location (the URI) or by their names. Because the
cache (and the "by_name" sub directory) is common across tests, it's a
good idea to make these names as distinct as possible.
This avoid name clashes, which makes future Avocado runs to attempt to
redownload the assets with the same name, but from the different
locations they actually are from. This causes cache misses, extra
downloads, and possibly canceled tests.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/avocado/kvm_xen_guest.py | 3 ++-
tests/avocado/netdev-ethtool.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py
index 5391283113..ec4052a1fe 100644
--- a/tests/avocado/kvm_xen_guest.py
+++ b/tests/avocado/kvm_xen_guest.py
@@ -40,7 +40,8 @@ def get_asset(self, name, sha1):
url = base_url + name
# use explicit name rather than failing to neatly parse the
# URL into a unique one
- return self.fetch_asset(name=name, locations=(url), asset_hash=sha1)
+ return self.fetch_asset(name=f"qemu-kvm-xen-guest-{name}",
+ locations=(url), asset_hash=sha1)
def common_vm_setup(self):
# We also catch lack of KVM_XEN support if we fail to launch
diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool.py
index 5f33288f81..462cf8de7d 100644
--- a/tests/avocado/netdev-ethtool.py
+++ b/tests/avocado/netdev-ethtool.py
@@ -27,7 +27,8 @@ def get_asset(self, name, sha1):
url = base_url + name
# use explicit name rather than failing to neatly parse the
# URL into a unique one
- return self.fetch_asset(name=name, locations=(url), asset_hash=sha1)
+ return self.fetch_asset(name=f"qemu-netdev-ethtool-{name}",
+ locations=(url), asset_hash=sha1)
def common_test_code(self, netdev, extra_args=None):
--
2.43.0
- [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset, (continued)
- [PATCH 07/10] testa/avocado: test_arm_emcraft_sf2: handle RW requirements for asset, Cleber Rosa, 2023/12/08
- [PATCH 02/10] tests/avocado: mips: add hint for fetchasset plugin, Cleber Rosa, 2023/12/08
- [PATCH 06/10] tests/avocado/kvm_xen_guest.py: cope with asset RW requirements, Cleber Rosa, 2023/12/08
- [PATCH 09/10] tests/avocado/boot_xen.py: unify tags, Cleber Rosa, 2023/12/08
- [PATCH 05/10] tests/avocado: use more distinct names for assets,
Cleber Rosa <=
- [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Cleber Rosa, 2023/12/08
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Alex Bennée, 2023/12/11
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Cleber Rosa, 2023/12/13
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Eric Auger, 2023/12/14
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Alex Bennée, 2023/12/14
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Eric Auger, 2023/12/14
- Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout, Philippe Mathieu-Daudé, 2023/12/14