[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix qemu build with xen-4.18.0
|
From: |
Richard W.M. Jones |
|
Subject: |
Re: [PATCH] fix qemu build with xen-4.18.0 |
|
Date: |
Fri, 8 Dec 2023 08:47:07 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
(Adding Xen maintainers)
On Thu, Dec 07, 2023 at 11:12:48PM +0000, Michael Young wrote:
> Builds of qemu-8.2.0rc2 with xen-4.18.0 are currently failing
> with errors like
> ../hw/arm/xen_arm.c:74:5: error: ‘GUEST_VIRTIO_MMIO_SPI_LAST’ undeclared
> (first use in this function)
> 74 | (GUEST_VIRTIO_MMIO_SPI_LAST - GUEST_VIRTIO_MMIO_SPI_FIRST)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> as there is an incorrect comparision in include/hw/xen/xen_native.h
> which means that settings like GUEST_VIRTIO_MMIO_SPI_LAST
> aren't being defined for xen-4.18.0
>
> Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> include/hw/xen/xen_native.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/xen/xen_native.h b/include/hw/xen/xen_native.h
> index 6f09c48823..04b1ef4d34 100644
> --- a/include/hw/xen/xen_native.h
> +++ b/include/hw/xen/xen_native.h
> @@ -532,7 +532,7 @@ static inline int
> xendevicemodel_set_irq_level(xendevicemodel_handle *dmod,
> }
> #endif
>
> -#if CONFIG_XEN_CTRL_INTERFACE_VERSION <= 41700
> +#if CONFIG_XEN_CTRL_INTERFACE_VERSION >= 41700
> #define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000)
> #define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x00100000)
> #define GUEST_VIRTIO_MMIO_SPI_FIRST 33
> --
> 2.43.0
>
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org