qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/11] replay: add proper kdoc for ReplayState


From: Pavel Dovgalyuk
Subject: Re: [PATCH 06/11] replay: add proper kdoc for ReplayState
Date: Thu, 7 Dec 2023 11:38:37 +0300
User-agent: Mozilla Thunderbird

On 05.12.2023 23:41, Alex Bennée wrote:
Remove the non-standard comment formatting and move the descriptions
into a proper kdoc comment.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  replay/replay-internal.h               | 27 ++++++++++++++++----------
  roms/SLOF                              |  2 +-
  tests/tcg/i386/Makefile.softmmu-target | 19 ++++++++++++++++++
  3 files changed, 37 insertions(+), 11 deletions(-)

diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 516147ddbc..98ca3748ed 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -63,24 +63,31 @@ enum ReplayEvents {
      EVENT_COUNT
  };
+/**
+ * typedef ReplayState - global tracking Replay state
+ *
+ * This structure tracks where we are in the current ReplayState
+ * including the logged events from the recorded replay stream. Some
+ * of the data is also stored/restored from VMStateDescription when VM
+ * save/restore events take place.
+ *
+ * @cached_clock: Cached clocks values
+ * @current_icount: number of processed instructions
+ * @instruction_count: number of instructions until next event
+ * @data_kind: current event
+ * @has_unread_data: 1 if event not yet processed
+ * @file_offset: offset into replay log at replay snapshot
+ * @block_request_id: current serialised block request id
+ * @read_event_id: current async read event id
+ */
  typedef struct ReplayState {
-    /*! Cached clock values. */
      int64_t cached_clock[REPLAY_CLOCK_COUNT];
-    /*! Current icount - number of processed instructions. */
      uint64_t current_icount;
-    /*! Number of instructions to be executed before other events happen. */
      int instruction_count;
-    /*! Type of the currently executed event. */
      unsigned int data_kind;
-    /*! Flag which indicates that event is not processed yet. */
      unsigned int has_unread_data;
-    /*! Temporary variable for saving current log offset. */
      uint64_t file_offset;
-    /*! Next block operation id.
-        This counter is global, because requests from different
-        block devices should not get overlapping ids. */
      uint64_t block_request_id;
-    /*! Asynchronous event id read from the log */
      uint64_t read_event_id;
  } ReplayState;
  extern ReplayState replay_state;


Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]