Re: [PATCH v2 for-8.2?] i386/sev: Avoid SEV-ES crash due to missing MSR_EFER_LMA bit

[Paolo Bonzini]

On Wed, Dec 6, 2023 at 2:13 PM Michael Roth <michael.roth@amd.com> wrote:
> > This 'Fixes:' tag is misleading, since as you mentioned this commit
> > only exposes the issue.
>
> That's true, a "Workaround-for: " tag or something like that might be more
> appropriate. I just wanted to make it clear that SEV-ES support is no longer
> working with that patch applied, so I used Fixes: and elaborated on the
> commit message. I can change it if there's a better way to convey this
> though.

That's fine, Fixes is also for automated checks, like "if you have
this commit you also want this one".

> >
> > Commit d499f196fe ("target/i386: Added consistency checks for EFER")
> > or around it seems more appropriate.
>
> Those checks seem to be more for TCG.

Yes, that's 100% TCG code.

> The actual bug is in the host
> kernel, and it seems to have been there basically since the original
> SEV-ES host support went in in 2020. I've also sent a patch to address
> this in KVM:
>
>   
> https://lore.kernel.org/lkml/20231205234956.1156210-1-michael.roth@amd.com/T/#u

Thanks, looking at it.

Paolo